Re: [PATCH 04/13] fat: only specify I_DIRTY_TIME when needed in fat_update_time()

On Thu, Jan 07, 2021 at 02:13:28PM +0100, Jan Kara wrote:

On Mon 04-01-21 16:54:43, Eric Biggers wrote:

quoted

From: Eric Biggers <redacted>

As was done for generic_update_time(), only pass I_DIRTY_TIME to
__mark_inode_dirty() when the inode's timestamps were actually updated
and lazytime is enabled.  This avoids a weird edge case where
I_DIRTY_TIME could be set in i_state when lazytime isn't enabled.

Signed-off-by: Eric Biggers <redacted>

...

quoted

+	if ((flags & S_VERSION) && inode_maybe_inc_iversion(inode, false))
+		dirty_flags |= I_DIRTY_SYNC;
 
-	if (dirty)
-		iflags |= I_DIRTY_SYNC;
 	__mark_inode_dirty(inode, iflags);

				  ^^^ dirty_flags here?

Otherwise the change looks good to me.

Yeah, I'll fix that.  I accidentally didn't have CONFIG_FAT_FS enabled.

- Eric