Re: [PATCH 2/5 resend] Thaw the journal when you unfreeze the fs.

On 12/6/11 5:07 AM, Matt Fleming wrote:

On Mon, 2011-12-05 at 12:54 -0800, Kamal Mostafa wrote:

quoted

From: Surbhi Palande <redacted>

Thaw the journal so that transactions can resume

BugLink: https://bugs.launchpad.net/bugs/897421
Signed-off-by: Surbhi Palande <redacted>
Cc: Kamal Mostafa <redacted>
Tested-by: Peter M. Petrakis <redacted>
Signed-off-by: Kamal Mostafa <redacted>
---
 fs/ext4/super.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

Shouldn't this patch really be merged with [PATCH 1/5] ? Otherwise it's
possible to freeze a journal that will never be unfrozen, if say, you're
doing a git bisect and you have [PATCH 1/5] applied but not [PATCH 2/5].

I second that; I was going to send the same comment but you beat
me to it.  Doing it this way will make it a tough go when bisecting
freeze issues, it needs to be rolled into patch 1.

Thanks,
-Eric