Thread (74 messages) 74 messages, 7 authors, 2020-09-11

Re: [PATCH 13/23] gpio: mockup: pass the chip label as device property

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2020-09-07 11:51:48
Also in: linux-acpi, linux-gpio, lkml

On Mon, Sep 07, 2020 at 01:01:02PM +0200, Bartosz Golaszewski wrote:
On Fri, Sep 4, 2020 at 6:48 PM Andy Shevchenko
[off-list ref] wrote:
quoted
On Fri, Sep 04, 2020 at 05:45:37PM +0200, Bartosz Golaszewski wrote:
quoted
From: Bartosz Golaszewski <redacted>

While we do check the "chip-name" property in probe(), we never actually
use it. Let's pass the chip label to the driver using device properties
as we'll want to allow users to define their own once dynamically
created chips are supported.

The property is renamed to "chip-label" to not cause any confusion with
the actual chip name which is of the form: "gpiochipX".

If the "chip-label" property is missing, let's do what most devices in
drivers/gpio/ do and use dev_name().
Just wondering if we have a documentation in kernel how this mockup mechanism
works and what kind of properties it uses.

Side note: moving to software nodes would make some advantages in future such
as visibility properties and their values (not yet implemented, but there is an
idea to move forward).
Seems like we're implicitly using software nodes already:
fwnode_create_software_node() is called when adding device properties.
It's not the same APIs, though the former is called from the latter.
But maybe for now it's okay.

-- 
With Best Regards,
Andy Shevchenko

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help