Thread (74 messages) 74 messages, 7 authors, 2020-09-11

Re: [PATCH 03/23] lib: uaccess: provide getline_from_user()

From: Bartosz Golaszewski <hidden>
Date: 2020-09-07 10:03:10
Also in: linux-acpi, linux-gpio, lkml

On Fri, Sep 4, 2020 at 6:35 PM Andy Shevchenko
[off-list ref] wrote:
On Fri, Sep 04, 2020 at 05:45:27PM +0200, Bartosz Golaszewski wrote:
quoted
From: Bartosz Golaszewski <redacted>

Provide a uaccess helper that allows callers to copy a single line from
user memory. This is useful for debugfs write callbacks.
Doesn't mm/util.c provides us something like this?
strndup_user()?
Yes, there's both strndup_user() as well as strncpy_from_user(). The
problem is that they rely on the strings being NULL-terminated. This
is not guaranteed for debugfs file_operations write callbacks. We need
some helper that takes the minimum of bytes provided by userspace and
the buffer size and figure out how many bytes to actually copy IMO.

Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help