Thread (74 messages) 74 messages, 7 authors, 2020-09-11

Re: [PATCH 06/23] gpiolib: switch to simpler IDA interface

From: Bartosz Golaszewski <hidden>
Date: 2020-09-07 10:50:24
Also in: linux-acpi, linux-gpio, lkml

On Fri, Sep 4, 2020 at 6:41 PM Andy Shevchenko
[off-list ref] wrote:
On Fri, Sep 04, 2020 at 05:45:30PM +0200, Bartosz Golaszewski wrote:
quoted
From: Bartosz Golaszewski <redacted>

We don't need to specify any ranges when allocating IDs so we can switch
to ida_alloc() and ida_free() instead of the ida_simple_ counterparts.

ida_simple_get(ida, 0, 0, gfp) is equivalent to
ida_alloc_range(ida, 0, UINT_MAX, gfp) which is equivalent to
ida_alloc(ida, gfp). Note: IDR will never actually allocate an ID
larger than INT_MAX.
Have you considered switching to XArray API?
IDA uses an xarray internally but wraps it in a more straightforward
API. No need to use the low-level API IMO.

Bart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help