Re: [PATCH v6 05/17] rtc: rzn1: Fix alarm range check truncation on 32-bit systems

From
sashiko-bot@kernel.org
Date
2026-08-21 21:22:29
Also in
linux-rtc
Reply to
Prabhakar, 2026-08-21
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

alarm and farest were declared as unsigned long, but
rtc_tm_to_time64() returns time64_t (s64). On 32-bit systems where
unsigned long is 32 bits, the assignment silently truncates the upper
32 bits of the timestamp.

Fix by declaring alarm and farest as time64_t and replacing
time_after() with a direct signed comparison, which is correct for
time64_t values that will never realistically overflow.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260821211032.13554-1-prabhakar.mahadev-lad.rj@bp.renesas.com?part=5
Thread (38 messages) 38 messages, 4 authors, last reply 2026-08-23
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help