Re: [PATCH v4 1/3] dt-bindings: mmc: sdhci-msm: Add ICE phandle
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2026-02-19 08:27:18
Also in:
linux-mmc, lkml
On 19/02/2026 06:38, Neeraj Soni wrote:
quoted
quoted
+ - if: + required: + - qcom,ice + then: + properties: + reg-names: + not: + contains: + const: iceAnd reg is still 4? This is not correct syntax. You need to define proper and final constraints per each device. I would write example, but why... more things you could just ignore.I had included changes for reg in v3: https://lore.kernel.org/all/20260206112053.3287756-2-neeraj.soni@oss.qualcomm.com/ (local) but those were not reviewed so i assume them to be incorrect and dropped it. Will fix this in next patch and post.
Patch v3 was also not correct, because SDHCI v5 devices should have 1 or 2 entries, not 1-3 as previous patch said. You need to embed the ifs: 189 - if: 190 properties: 191 compatible: 192 contains: 193 enum: 194 - qcom,sdhci-msm-v4 195 then: here you add one more if: 196 properties: 197 reg: 198 minItems: 2 199 items: 200 - description: Host controller register map 201 - description: SD Core register map 202 - description: CQE register map 203 - description: Inline Crypto Engine register map 204 reg-names: 205 minItems: 2 206 items: 207 - const: hc 208 - const: core 209 - const: cqhci 210 - const: ice 211 else: and here as well. 212 properties: 213 reg: 214 minItems: 1 215 items: 216 - description: Host controller register map 217 - description: CQE register map 218 - description: Inline Crypto Engine register map 219 reg-names: 220 minItems: 1 221 items: 222 - const: hc 223 - const: cqhci 224 - const: ice At least that's the simplest solution I see now. Best regards, Krzysztof