Thread (32 messages) 32 messages, 3 authors, 2026-02-09

Re: [PATCH v4 06/13] iio: dac: ds4424: use device match data for chip info

From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: 2026-02-03 12:00:05
Also in: linux-iio, lkml

On Tue, Feb 03, 2026 at 01:51:23PM +0200, Andy Shevchenko wrote:
On Tue, Feb 03, 2026 at 11:17:42AM +0100, Oleksij Rempel wrote:
quoted
On Tue, Feb 03, 2026 at 12:03:23PM +0200, Andy Shevchenko wrote:
quoted
On Tue, Feb 03, 2026 at 10:34:26AM +0100, Oleksij Rempel wrote:
...
quoted
quoted
quoted
-	indio_dev->name = id->name;
quoted
+	indio_dev->name = client->name;
Isn't this an ABI breakage?
I can't confirm it.

before all patches:
root@DistroKit:~ cat /sys/bus/iio/devices/iio:device3/name 
ds4424

after:
root@DistroKit:~ cat /sys/bus/iio/devices/iio:device3/name 
ds4424
In ACPI case it might look differently, but I have no means to test this.

id->name comes strictly from an i2c table, while client->name is constructed
using specifics of the firmware enumeration. In DT due to some (historical?)
reasons the client->name has no vendor substring and hence matches 1:1 to
id->name. In ACPI, IIRC, the client->name is ACPI device instance name,
something like ABCD0123:00.
Ok, I see. Should I revert this line?

Thank you,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help