On 07/09/2025 23:55, Andy Shevchenko wrote:

On Sun, Sep 7, 2025 at 2:42 PM Jonathan Cameron [off-list ref] wrote:

quoted

On Fri, 5 Sep 2025 09:42:31 +0300
Matti Vaittinen [off-list ref] wrote:

...

quoted

quoted

+/* ADC channels as named in the data-sheet */
+static const char * const bd79112_chan_names[] = {
+     "AGIO0A", "AGIO1A", "AGIO2A", "AGIO3A", "AGIO4A",       /* 0 - 4 */
+     "AGIO5A", "AGIO6A", "AGIO7A", "AGIO8A", "AGIO9A",       /* 5 - 9 */
+     "AGIO10A", "AGIO11A", "AGIO12A", "AGIO13A", "AGIO14A",  /* 10 - 14 */
+     "AGIO15A", "AGIO0B", "AGIO1B", "AGIO2B", "AGIO3B",      /* 15 - 19 */
+     "AGIO4B", "AGIO5B", "AGIO6B", "AGIO7B", "AGIO8B",       /* 20 - 24 */
+     "AGIO9B", "AGIO10B", "AGIO11B", "AGIO12B", "AGIO13B",   /* 25 - 29 */
+     "AGIO14B", "AGIO15B",                                   /* 30 - 31 */
+};

quoted

+     /* Let's assign data-sheet names to channels */

Not seeing any value in this comment given the code that follows.
Probably drop it

It was my suggestion. I don't know if you noticed that the amount of> the values is *not* power-of-two and it's harder to find a needed
value in the list. Moreover, you can read the discussion back and find
that actually it was a mistake in the list, which can be avoided (or
chances of which will be minimized) in the first place if we see the
comments.

I believe Jonathan meant the:
 >>> +/* ADC channels as named in the data-sheet */

not the "index comments". And I kinda agree with him, that's not adding 
too much. I'll drop that as suggested.

Yours,
	-- Matti