Re: [PATCH v3 2/3] iio: adc: Support ROHM BD79112 ADC/GPIO
From: Jonathan Cameron <jic23@kernel.org>
Date: 2025-09-07 11:42:21
Also in:
linux-gpio, linux-iio, lkml
On Fri, 5 Sep 2025 09:42:31 +0300 Matti Vaittinen [off-list ref] wrote:
The ROHM BD79112 is an ADC/GPIO with 32 channels. The channel inputs can be used as ADC or GPIO. Using the GPIOs as IRQ sources isn't supported. The ADC is 12-bit, supporting input voltages up to 5.7V, and separate I/O voltage supply. Maximum SPI clock rate is 20 MHz (10 MHz with daisy-chain configuration) and maximum sampling rate is 1MSPS. The IC does also support CRC but it is not implemented in the driver. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Hi Matti, Just one trivial additional comment from me. Jonathan
quoted hunk ↗ jump to hunk
diff --git a/drivers/iio/adc/rohm-bd79112.c b/drivers/iio/adc/rohm-bd79112.c new file mode 100644 index 000000000000..8acd1e5f105d --- /dev/null +++ b/drivers/iio/adc/rohm-bd79112.c
+
+/* ADC channels as named in the data-sheet */
+static const char * const bd79112_chan_names[] = {
+ "AGIO0A", "AGIO1A", "AGIO2A", "AGIO3A", "AGIO4A", /* 0 - 4 */
+ "AGIO5A", "AGIO6A", "AGIO7A", "AGIO8A", "AGIO9A", /* 5 - 9 */
+ "AGIO10A", "AGIO11A", "AGIO12A", "AGIO13A", "AGIO14A", /* 10 - 14 */
+ "AGIO15A", "AGIO0B", "AGIO1B", "AGIO2B", "AGIO3B", /* 15 - 19 */
+ "AGIO4B", "AGIO5B", "AGIO6B", "AGIO7B", "AGIO8B", /* 20 - 24 */
+ "AGIO9B", "AGIO10B", "AGIO11B", "AGIO12B", "AGIO13B", /* 25 - 29 */
+ "AGIO14B", "AGIO15B", /* 30 - 31 */
+};+ /* Let's assign data-sheet names to channels */
Not seeing any value in this comment given the code that follows. Probably drop it
+ for (i = 0; i < iio_dev->num_channels; i++) {
+ unsigned int ch = cs[i].channel;
+
+ cs[i].datasheet_name = bd79112_chan_names[ch];
+ }