Re: [PATCH v3 1/3] dt-bindings: iio: adc: ROHM BD79112 ADC/GPIO
From: Matti Vaittinen <mazziesaccount@gmail.com>
Date: 2025-09-07 12:37:44
Also in:
linux-gpio, linux-iio, lkml
On 07/09/2025 14:19, Jonathan Cameron wrote:
On Fri, 5 Sep 2025 09:42:18 +0300 Matti Vaittinen [off-list ref] wrote:quoted
The ROHM BD79112 is an ADC/GPIO with 32 channels. The channel inputs can be used as ADC or GPIO. Using the GPIOs as IRQ sources isn't supported. The ADC is 12-bit, supporting input voltages up to 5.7V, and separate I/O voltage supply. Maximum SPI clock rate is 20 MHz (10 MHz with daisy-chain configuration) and maximum sampling rate is 1MSPS. Add a device tree binding document for the ROHM BD79112. Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> Acked-by: Conor Dooley <conor.dooley@microchip.com>Trivial comment below. If everything else is good on this version it isn't worth a respin.quoted
+examples: + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + adc: adc@0 { + compatible = "rohm,bd79112"; + reg = <0x0>; + + spi-cpha; + spi-cpol; + + vdd-supply = <&dummyreg>; + iovdd-supply = <&dummyreg>; + + #address-cells = <1>; + #size-cells = <0>; + + gpio-controller; + #gpio-cells = <2>; + + channel@0 { + reg = <0>; + }; + channel@1 { + reg = <1>; + }; + channel@2 { + reg = <2>; + }; + channel@3 { + reg = <3>;Trivial point but I get bored scrolling. Would a smaller set of channels allow you to provide same level of testing / documentation?
I suppose yes. Trimming this to maybe 3 channels would be just fine. I'll re-spin the series anyways so I'll crop this too. Yours, -- Matti