Re: [PATCH 4/7] phy: allwinner: a523: add USB3/PCIe PHY driver
From: Chukun Pan <hidden>
Date: 2025-08-27 06:40:26
Also in:
linux-arm-kernel, linux-clk, linux-phy, linux-sunxi, lkml
Hi,
quoted hunk ↗ jump to hunk
--- a/drivers/phy/allwinner/Makefile +++ b/drivers/phy/allwinner/Makefile@@ -3,3 +3,4 @@ obj-$(CONFIG_PHY_SUN4I_USB) += phy-sun4i-usb.o obj-$(CONFIG_PHY_SUN6I_MIPI_DPHY) += phy-sun6i-mipi-dphy.o obj-$(CONFIG_PHY_SUN9I_USB) += phy-sun9i-usb.o obj-$(CONFIG_PHY_SUN50I_USB3) += phy-sun50i-usb3.o +obj-$(CONFIG_PHY_SUN55I_USB3_PCIE) += phy-sun55i-usb3-pcie.o
Would it be better to call it phy-sun55i-combophy ?
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/phy/allwinner/phy-sun55i-usb3-pcie.c... +static int sun55i_usb3_pcie_phy_init(struct phy *_phy) +{ + struct sun55i_usb3_pcie_phy *phy = phy_get_drvdata(_phy); + + sun55i_usb3_phy_open(phy);
Maybe we need to add `case PHY_TYPE_USB3:` And use <&combophy PHY_TYPE_USB3> in the DT
+ + return 0; +} ...
+static const struct of_device_id sun55i_usb3_pcie_phy_of_match[] = {
+ { .compatible = "allwinner,sun55i-a523-usb3-pcie-phy" },Would it be better to use "allwinner,sun55i-a523-combophy" as the compatible?
+ { },
+};
+MODULE_DEVICE_TABLE(of, sun55i_usb3_pcie_phy_of_match);Thanks, Chukun