Re: [PATCH v2 04/12] media: ipu-bridge: Use v4l2_fwnode_device_parse helper
From: Hans de Goede <hansg@kernel.org>
Date: 2025-07-14 13:11:50
Also in:
linux-acpi, linux-gpio, linux-media, linux-usb, lkml
Hi, On 5-Jun-25 19:52, Ricardo Ribalda wrote:
quoted hunk ↗ jump to hunk
v4l2_fwnode_device_parse now supports acpi devices as well. Use the helper instead of re-implement the logic. Signed-off-by: Ricardo Ribalda <redacted> --- drivers/media/pci/intel/ipu-bridge.c | 32 ++++++-------------------------- 1 file changed, 6 insertions(+), 26 deletions(-)diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c index 83e682e1a4b77d9d97b2988750732d0b7c9087b3..020aa52f590d66b6d333adc56ebfb9ab0561db51 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c@@ -253,36 +253,16 @@ static u32 ipu_bridge_parse_rotation(struct acpi_device *adev, static enum v4l2_fwnode_orientation ipu_bridge_parse_orientation(struct acpi_device *adev) {
In patch 5/12 you add a "struct v4l2_fwnode_device_properties *props" parameter to this function and move the calling of v4l2_fwnode_device_parse() to ipu_bridge_parse_ssdb(). You might just as well do this here so that there is a bit less churn in the series. Regards, Hans
- enum v4l2_fwnode_orientation orientation;
- struct acpi_pld_info *pld = NULL;
+ struct v4l2_fwnode_device_properties props;
+ int ret;
- if (!acpi_get_physical_device_location(ACPI_PTR(adev->handle), &pld)) {
- dev_warn(ADEV_DEV(adev), "_PLD call failed, using default orientation\n");
+ ret = v4l2_fwnode_device_parse(ADEV_DEV(adev), &props);
+ if (!ret || props.rotation == V4L2_FWNODE_PROPERTY_UNSET) {
+ dev_warn(ADEV_DEV(adev), "Using default orientation\n");
return V4L2_FWNODE_ORIENTATION_EXTERNAL;
}
- switch (pld->panel) {
- case ACPI_PLD_PANEL_FRONT:
- orientation = V4L2_FWNODE_ORIENTATION_FRONT;
- break;
- case ACPI_PLD_PANEL_BACK:
- orientation = V4L2_FWNODE_ORIENTATION_BACK;
- break;
- case ACPI_PLD_PANEL_TOP:
- case ACPI_PLD_PANEL_LEFT:
- case ACPI_PLD_PANEL_RIGHT:
- case ACPI_PLD_PANEL_UNKNOWN:
- orientation = V4L2_FWNODE_ORIENTATION_EXTERNAL;
- break;
- default:
- dev_warn(ADEV_DEV(adev), "Unknown _PLD panel val %d\n",
- pld->panel);
- orientation = V4L2_FWNODE_ORIENTATION_EXTERNAL;
- break;
- }
-
- ACPI_FREE(pld);
- return orientation;
+ return props.orientation;
}
int ipu_bridge_parse_ssdb(struct acpi_device *adev, struct ipu_sensor *sensor)