Re: [PATCH v2 03/12] ACPI: mipi-disco-img: Do not duplicate rotation info into swnodes
From: Hans de Goede <hansg@kernel.org>
Date: 2025-07-14 13:08:27
Also in:
linux-acpi, linux-gpio, linux-media, linux-usb, lkml
Hi, On 5-Jun-25 19:52, Ricardo Ribalda wrote:
The function v4l2_fwnode_device_parse() is not capable of parsint the _PLD method, there is no need to duplicate the rotation information in a swnode. Signed-off-by: Ricardo Ribalda <redacted>
Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hansg@kernel.org> with Sakari's review remarks addressed. Regards, Hans
quoted hunk ↗ jump to hunk
--- drivers/acpi/mipi-disco-img.c | 15 --------------- 1 file changed, 15 deletions(-)diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c index 5b85989f96beeb726f59ac9e12e965a215fb38f6..b58b5ba22a47a4afc5212998074d322f0b7586dc 100644 --- a/drivers/acpi/mipi-disco-img.c +++ b/drivers/acpi/mipi-disco-img.c@@ -617,21 +617,6 @@ static void init_crs_csi2_swnodes(struct crs_csi2 *csi2) adev_fwnode = acpi_fwnode_handle(adev); - /* - * If the "rotation" property is not present, but _PLD is there, - * evaluate it to get the "rotation" value. - */ - if (!fwnode_property_present(adev_fwnode, "rotation")) { - struct acpi_pld_info *pld; - - if (acpi_get_physical_device_location(handle, &pld)) { - swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_ROTATION)] = - PROPERTY_ENTRY_U32("rotation", - pld->rotation * 45U); - kfree(pld); - } - } - if (!fwnode_property_read_u32(adev_fwnode, "mipi-img-clock-frequency", &val)) swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_CLOCK_FREQUENCY)] = PROPERTY_ENTRY_U32("clock-frequency", val);