Re: [PATCH v2 01/12] media: uvcvideo: Always set default_value
From: Hans de Goede <hansg@kernel.org>
Date: 2025-07-14 13:00:55
Also in:
linux-acpi, linux-gpio, linux-media, linux-usb, lkml
Hi, On 5-Jun-25 19:52, Ricardo Ribalda wrote:
If the control does not support GET_DEF, the field default_value will be
left uninitialized during queryctrl.
Fixes: c0efd232929c ("V4L/DVB (8145a): USB Video Class driver")
Signed-off-by: Ricardo Ribalda <redacted>Thanks, patch looks good to me, Reviewed-by: Hans de Goede <hansg@kernel.org> with Laurent's remarks addressed. Regards, Hans
quoted hunk ↗ jump to hunk
--- drivers/media/usb/uvc/uvc_ctrl.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c index 44b6513c526421943bb9841fb53dc5f8e9f93f02..47e8ccc39234d1769384b55539a21df07f3d57c7 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c@@ -1497,6 +1497,8 @@ static int __uvc_queryctrl_boundaries(struct uvc_video_chain *chain, if (ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF) { v4l2_ctrl->default_value = uvc_mapping_get_s32(mapping, UVC_GET_DEF, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF)); + } else { + v4l2_ctrl->default_value = 0; } switch (mapping->v4l2_type) {