Hi Claudiu,

On Wed, Sep 13, 2023 at 7:32 AM claudiu beznea [off-list ref] wrote:

On 12.09.2023 19:16, Rob Herring wrote:

quoted

On Tue, Sep 12, 2023 at 07:51:55AM +0300, Claudiu wrote:

quoted

From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Document Renesas SMARC Carrier-II EVK board which is based on RZ/G3S
(R9A08G045) SoC. The SMARC Carrier-II EVK consists of RZ/G3S SoM module and
SMARC Carrier-II carrier board, the SoM module sits on top of carrier
board.

Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Thanks for your patch!

quoted

quoted

--- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
+++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml

@@ -476,6 +476,8 @@ properties:

       - description: RZ/G3S (R9A08G045)
         items:
+          - enum:
+              - renesas,smarc2-evk # SMARC Carrier-II EVK

You just changed the existing binding...

quoted

           - enum:
               - renesas,r9a08g045s33 # PCIe support

This is the SoM module?

No, this is a SoC variant which supports PCIe.

Ideally, we need a compatible value for the SoM as well, as the SoM
can be used stand-alone, or plugged in a different carrier board.

For iWave Systems RZ/G1E SODIMM, we have that.
For the existing RZ/G2L variants, we forgot, but it can still be added...

quoted

You either need to squash this change or add
another case with 3 entries and maintain the 2 entry case. (there's no
way to express any entry at the beginning or middle can be optional)

quoted

           - const: renesas,r9a08g045

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds