On Mon, Jul 18, 2022 at 12:48 PM Nuno Sá [off-list ref] wrote:

On Mon, 2022-07-18 at 12:32 +0200, Linus Walleij wrote:

quoted

On Wed, Jul 13, 2022 at 3:13 PM Nuno Sá [off-list ref] wrote:

quoted

On top of looking at PULL_UP and PULL_DOWN flags, also look at
PULL_DISABLE and set the appropriate GPIO flag. The GPIO core will
then
pass down this to controllers that support it.

Signed-off-by: Nuno Sá <nuno.sa@analog.com>

Do we have a semantic check that PULLDOWN and PULLUP
is not used in combination with NOPULL here?

(We should also be checking that PULLDOWN and PULLUP
are not used simultaneously but that is an unrelated thing.)

I did extended this check:

https://elixir.bootlin.com/linux/v5.19-rc7/source/drivers/gpio/gpiolib.c#L3948

on patch 1 to make sure that PULLDOWN and PULLUP are not used with
NOPULL. Is this what you have in mind or is it something else?

Excellent, thanks! That is exactly what we need, sorry for not being
able to keep all floating patches in my head :D

Yours,
Linus Walleij