Re: [PATCH 3/5] pinctrl: add helpers reading pins, groups & functions from DT

On Thu, Nov 18, 2021 at 2:58 PM Andy Shevchenko
[off-list ref] wrote:

On Thu, Nov 18, 2021 at 3:22 PM Rafał Miłecki [off-list ref] wrote:

quoted

+#include <linux/of.h>

I don't like this. This shows not thought through the design of the series.

What I rather expect is a proper interfacing layer that you fill with
options that can be provided by corresponding underlying
implementation, e.g. DT.

I agree, the DT parts should land in pinctrl/devicetree.c in the
end with an opt-in for ACPI & board files. I don't know if we
can use software nodes fully instead of board file-specific
helpers at this point, it seems to have
grown pretty competent.

Yours,
Linus Walleij