Re: [PATCH 3/5] pinctrl: add helpers reading pins, groups & functions from DT
From: Andy Shevchenko <hidden>
Date: 2021-11-18 13:58:25
Also in:
linux-arm-kernel, linux-gpio
On Thu, Nov 18, 2021 at 3:22 PM Rafał Miłecki [off-list ref] wrote: ...
quoted hunk ↗ jump to hunk
--- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c
+#include <linux/of.h>
I don't like this. This shows not thought through the design of the series. What I rather expect is a proper interfacing layer that you fill with options that can be provided by corresponding underlying implementation, e.g. DT. Moreover, before doing this you probably would need to refactor the pin control core to get rid of DT specifics, i.e. abstract them away first. -- With Best Regards, Andy Shevchenko