On 11/9/21 12:46 PM, Joe Perches wrote:

On Tue, 2021-11-09 at 11:11 -0800, Randy Dunlap wrote:

quoted

On 11/9/21 10:21 AM, Joe Perches wrote:

quoted

(cc'ing Andi Kleen, who wrote this code a decade ago)

quoted

Joe, can you identify why checkpatch does not detect missing Kconfig
help text is this simple case?

Original patch here: https://lore.kernel.org/all/20211028101840.24632-11-andrea.merello@gmail.com/raw (local)

checkpatch is counting the diff header lines that follow the config entry.
Maybe this is clearer (better?) code:
---

Tested-by: Randy Dunlap <redacted>
Acked-by: Randy Dunlap <redacted>

Hey Randy/Andi.

I like this patch below a bit more.

It shows the Kconfig context block in the output message and
documents the code a bit more.

Care to test it again?
---
  scripts/checkpatch.pl | 53 +++++++++++++++++++++++++++------------------------
  1 file changed, 28 insertions(+), 25 deletions(-)

Same tags from me, better output. Thanks!

Tested-by: Randy Dunlap <redacted>
Acked-by: Randy Dunlap <redacted>

-- 
~Randy