Re: [PATCH 07/13] dt-bindings: rtc: add bindings for microchip mpfs rtc
From: Krzysztof Kozlowski <hidden>
Date: 2021-11-08 21:20:31
Also in:
linux-crypto, linux-gpio, linux-i2c, linux-riscv, linux-rtc, linux-spi, linux-usb, lkml
On 08/11/2021 16:05, conor.dooley@microchip.com wrote:
quoted hunk ↗ jump to hunk
From: Conor Dooley <conor.dooley@microchip.com> Add device tree bindings for the real time clock on the Microchip PolarFire SoC. Signed-off-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com> --- .../bindings/rtc/microchip,mfps-rtc.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yamldiff --git a/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml new file mode 100644 index 000000000000..c82b3e7351e0 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/microchip,mfps-rtc.yaml@@ -0,0 +1,61 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/microchip,mfps-rtc.yaml# + +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip PolarFire Soc (MPFS) RTC Device Tree Bindings + +allOf: + - $ref: "rtc.yaml#"
No need for quotes.
quoted hunk ↗ jump to hunk
+ +maintainers: + - Daire McNamara <daire.mcnamara@microchip.com> + - Lewis Hanly <lewis.hanly@microchip.com> + +properties: + compatible: + enum: + - microchip,mpfs-rtc + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + prescaler: + maxItems: 1
You need to describe the type and add description. This does not look like standard property, so it needs vendor prefix.
quoted hunk ↗ jump to hunk
+ + clocks: + maxItems: 1 + + clock-names: + items: + - const: rtc + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/microchip,mpfs-clock.h> + soc { + #address-cells = <2>; + #size-cells = <2>;
Add a blank line before new node. The same in previous examples.
quoted hunk ↗ jump to hunk
+ rtc@20124000 { + compatible = "microchip,mpfs-rtc"; + reg = <0 0x20124000 0 0x1000>; + clocks = <&clkcfg CLK_RTC>; + clock-names = "rtc"; + interrupts = <80>; + }; + }; +...
Best regards, Krzysztof