Thread (43 messages) 43 messages, 5 authors, 2021-10-08
STALE1719d

[RFC PATCH] hwmon: tmp421_disable_channels() can be static

From: kernel test robot <hidden>
Date: 2021-09-09 20:40:57
Also in: linux-hwmon, oe-kbuild-all
Subsystem: hardware monitoring, the rest · Maintainers: Guenter Roeck, Linus Torvalds

drivers/hwmon/tmp421.c:356:6: warning: symbol 'tmp421_disable_channels' was not declared. Should it be static?

Reported-by: kernel test robot <redacted>
Signed-off-by: kernel test robot <redacted>
---
 tmp421.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
index cec25fb1c7719..162798f7491d9 100644
--- a/drivers/hwmon/tmp421.c
+++ b/drivers/hwmon/tmp421.c
@@ -353,7 +353,7 @@ void tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data)
 	}
 }
 
-void tmp421_disable_channels(struct i2c_client *client, uint8_t mask)
+static void tmp421_disable_channels(struct i2c_client *client, uint8_t mask)
 {
 	int err;
 	int cfg = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_2);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help