Re: [PATCH 8/8] dt-bindings: hwmon: allow specifying channels for tmp421
From: Guenter Roeck <linux@roeck-us.net>
Date: 2021-09-07 15:46:57
Also in:
linux-hwmon
On 9/7/21 6:46 AM, Krzysztof Adamski wrote:
Add binding description for the per temperature channel configuration like labels and n-factor. Signed-off-by: Krzysztof Adamski <redacted>
Up to Rob to decide, but it seems to me that can be squashed with the other dt patch in the series (which on its own doesn't really add much value). Guenter
quoted hunk ↗ jump to hunk
--- .../devicetree/bindings/hwmon/tmp421.yaml | 66 +++++++++++++++++++ 1 file changed, 66 insertions(+)diff --git a/Documentation/devicetree/bindings/hwmon/tmp421.yaml b/Documentation/devicetree/bindings/hwmon/tmp421.yaml index 53940e146ee6..56085fdf1b57 100644 --- a/Documentation/devicetree/bindings/hwmon/tmp421.yaml +++ b/Documentation/devicetree/bindings/hwmon/tmp421.yaml@@ -24,12 +24,49 @@ properties: reg: maxItems: 1 + '#address-cells': + const: 1 + + '#size-cells': + const: 0 + required: - compatible - reg additionalProperties: false +patternProperties: + "^input@([0-4])$": + type: object + description: | + Represents channels of the device and their specific configuration. + + properties: + reg: + description: | + The channel number. 0 is local channel, 1-4 are remote channels + items: + minimum: 0 + maximum: 4 + + label: + description: | + A descriptive name for this channel, like "ambient" or "psu". + + n-factor: + description: | + The value (two's complement) to be programmed in the channel specific N correction register. + For remote channels only. + items: + minimum: 0 + maximum: 1 + + required: + - reg + + additionalProperties: false + examples: - | i2c {@@ -41,3 +78,32 @@ examples: reg = <0x4c>; }; }; + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + sensor@4c { + compatible = "ti,tmp422"; + reg = <0x4c>; + #address-cells = <1>; + #size-cells = <0>; + + input@0 { + reg = <0x0>; + n-factor = <0x1>; + label = "local"; + }; + + input@1 { + reg = <0x1>; + n-factor = <0x0>; + label = "somelabel"; + }; + + input@2 { + reg = <0x2>; + status = "disabled"; + }; + }; + };