Thread (43 messages) 43 messages, 5 authors, 2021-10-08
STALE1714d

[RFC PATCH] hwmon: tmp421_probe_child_from_dt() can be static

From: kernel test robot <hidden>
Date: 2021-09-09 17:30:05
Also in: linux-hwmon, oe-kbuild-all
Subsystem: hardware monitoring, the rest · Maintainers: Guenter Roeck, Linus Torvalds

drivers/hwmon/tmp421.c:295:6: warning: symbol 'tmp421_probe_child_from_dt' was not declared. Should it be static?
drivers/hwmon/tmp421.c:319:6: warning: symbol 'tmp421_probe_from_dt' was not declared. Should it be static?

Reported-by: kernel test robot <redacted>
Signed-off-by: kernel test robot <redacted>
---
 tmp421.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwmon/tmp421.c b/drivers/hwmon/tmp421.c
index a1dba1d405ee8..5f1f3ec9f51c1 100644
--- a/drivers/hwmon/tmp421.c
+++ b/drivers/hwmon/tmp421.c
@@ -292,7 +292,7 @@ static int tmp421_detect(struct i2c_client *client,
 	return 0;
 }
 
-void tmp421_probe_child_from_dt(struct i2c_client *client,
+static void tmp421_probe_child_from_dt(struct i2c_client *client,
 				struct device_node *child,
 				struct tmp421_data *data)
 
@@ -316,7 +316,7 @@ void tmp421_probe_child_from_dt(struct i2c_client *client,
 
 }
 
-void tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data)
+static void tmp421_probe_from_dt(struct i2c_client *client, struct tmp421_data *data)
 {
 	struct device *dev = &client->dev;
 	const struct device_node *np = dev->of_node;
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help