Re: [RFC PATCH net-next 3/5] net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag

Hi Andrew,

On 8/23/21 1:14 AM, Andrew Lunn wrote:

quoted

quoted

quoted

+ */
+
+#include <linux/etherdevice.h>
+#include <linux/bits.h>
+
+#include "dsa_priv.h"
+
+#define RTL8_4_TAG_LEN			8
+#define RTL8_4_ETHERTYPE		0x8899

Please add this to include/uapi/linux/if_ether.h

Maybe call it ETH_P_REALTEK, and comment /* Multiple Proprietary
protocols */ ?

If you do it in an individual patch, you can explain more in the
commit message about it being used for different protocols by Realtek,
and that no assumptions should be made when trying to decode it.

Sounds good, I'll do that in v2.

	  Andrew