Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

On Tue Aug 10, 2021 at 3:55 PM EDT, Andy Shevchenko wrote:

On Tue, Aug 10, 2021 at 10:46 PM Liam Beguin [off-list ref]
wrote:

quoted

On Tue Aug 10, 2021 at 8:15 AM EDT, Andy Shevchenko wrote:

quoted

On Mon, Aug 9, 2021 at 1:50 AM Liam Beguin [off-list ref] wrote:

quoted

On Sun Aug 8, 2021 at 12:36 PM EDT, Jonathan Cameron wrote:

quoted

On Sat, 7 Aug 2021 21:56:57 -0400

        ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
        if (ret == -EINVAL && mode & AD7949_CFG_VAL_REF_EXTERNAL) {
                continue;

quoted

        } else if (ret < 0) {

quoted

quoted

Side note, redundant 'else'

Are you asking to add an 'else' statement?

because, unless I'm mistaken, in this case ret can have other negative values
that we want to catch with this 'else if'.

You lost me, I have no idea what "to add" and "other" mean here. No, I
asked to remove it. It's redundant.

Oh, I see what you meant now. I'll fix it. Thanks!

Liam

quoted

quoted

quoted

                dev_err(dev, "invalid voltage reference in %pfw\n", child);
                fwnode_handle_put(child);
                return ret;
        }

--
With Best Regards,
Andy Shevchenko