Re: [PATCH v5 3/5] iio: adc: ad7949: add support for internal vref

On Mon, Aug 9, 2021 at 1:50 AM Liam Beguin [off-list ref] wrote:

On Sun Aug 8, 2021 at 12:36 PM EDT, Jonathan Cameron wrote:

quoted

On Sat, 7 Aug 2021 21:56:57 -0400

        ret = fwnode_property_read_u32(child, "adi,internal-ref-microvolt", &tmp);
        if (ret == -EINVAL && mode & AD7949_CFG_VAL_REF_EXTERNAL) {
                continue;

        } else if (ret < 0) {

Side note, redundant 'else'

                dev_err(dev, "invalid voltage reference in %pfw\n", child);
                fwnode_handle_put(child);
                return ret;
        }

-- 
With Best Regards,
Andy Shevchenko