Re: [PATCH v2 05/11] dt-bindings: phy: renesas,usb2-phy: Document RZ/G2L phy bindings
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2021-06-22 15:34:02
Also in:
linux-phy, linux-renesas-soc
Hi Biju, On Mon, Jun 21, 2021 at 11:40 AM Biju Das [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Document USB phy bindings for RZ/G2L SoC. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- .../bindings/phy/renesas,usb2-phy.yaml | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-)diff --git a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml index 0f358d5b84ef..eebba6c83aec 100644 --- a/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml +++ b/Documentation/devicetree/bindings/phy/renesas,usb2-phy.yaml@@ -17,17 +17,18 @@ properties: - items: - enum: - - renesas,usb2-phy-r7s9210 # RZ/A2 - - renesas,usb2-phy-r8a774a1 # RZ/G2M - - renesas,usb2-phy-r8a774b1 # RZ/G2N - - renesas,usb2-phy-r8a774c0 # RZ/G2E - - renesas,usb2-phy-r8a774e1 # RZ/G2H - - renesas,usb2-phy-r8a7795 # R-Car H3 - - renesas,usb2-phy-r8a7796 # R-Car M3-W - - renesas,usb2-phy-r8a77961 # R-Car M3-W+ - - renesas,usb2-phy-r8a77965 # R-Car M3-N - - renesas,usb2-phy-r8a77990 # R-Car E3 - - renesas,usb2-phy-r8a77995 # R-Car D3 + - renesas,usb2-phy-r7s9210 # RZ/A2 + - renesas,usb2-phy-r8a774a1 # RZ/G2M + - renesas,usb2-phy-r8a774b1 # RZ/G2N + - renesas,usb2-phy-r8a774c0 # RZ/G2E + - renesas,usb2-phy-r8a774e1 # RZ/G2H + - renesas,usb2-phy-r8a7795 # R-Car H3 + - renesas,usb2-phy-r8a7796 # R-Car M3-W + - renesas,usb2-phy-r8a77961 # R-Car M3-W+ + - renesas,usb2-phy-r8a77965 # R-Car M3-N + - renesas,usb2-phy-r8a77990 # R-Car E3 + - renesas,usb2-phy-r8a77995 # R-Car D3 + - renesas,usb2-phy-r9a07g044 # RZ/G2{L,LC} - const: renesas,rcar-gen3-usb2-phy reg:
As some of the register bits are different, cfr. my comments to
[PATCH v2 10/11], I think you want to add a new oneOf instead:
- items:
- enum:
- renesas,usb2-phy-r9a07g044 # RZ/G2{L,LC}
- const: renesas,rzg2l-usb2-phy
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds