RE: [PATCH v2 06/11] dt-bindings: usb: generic-ohci: Document RZ/G2L SoC bindings
From: Biju Das <biju.das.jz@bp.renesas.com>
Date: 2021-06-22 10:04:00
Also in:
linux-renesas-soc, linux-usb
Hi Rob, I can reproduce the issue now, after installing 'yamllint' and using "DT_CHECKER_FLAGS=-m dt_binding_check". I will fix this and send v3. Regards, Biju
-----Original Message----- From: Rob Herring <robh@kernel.org> Sent: 21 June 2021 18:40 To: Biju Das <biju.das.jz@bp.renesas.com> Cc: Rob Herring <robh+dt@kernel.org>; Yoshihiro Shimoda [off-list ref]; Chris Paterson [off-list ref]; linux-usb@vger.kernel.org; Greg Kroah- Hartman [off-list ref]; Geert Uytterhoeven [off-list ref]; Biju Das [off-list ref]; linux- renesas-soc@vger.kernel.org; Prabhakar Mahadev Lad <prabhakar.mahadev- lad.rj@bp.renesas.com>; devicetree@vger.kernel.org Subject: Re: [PATCH v2 06/11] dt-bindings: usb: generic-ohci: Document RZ/G2L SoC bindings On Mon, 21 Jun 2021 10:39:38 +0100, Biju Das wrote:quoted
Renesas RZ/G2L SoC has USBPHY Control and USB2.0 PHY module. We need to turn on both these phy modules before accessing host registers. Apart from this, document the optional property dr_mode present on both RZ/G2 and R-Car Gen3 SoCs. Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> --- .../devicetree/bindings/usb/generic-ohci.yaml | 32 +++++++++++++++++-- 1 file changed, 30 insertions(+), 2 deletions(-)My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/generic-ohci.yaml:14:13: [warning] wrong indentation: expected 10 but found 12 (indentation) dtschema/dtc warnings/errors: \ndoc reference errors (make refcheckdocs): See https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwor k.ozlabs.org%2Fpatch%2F1494981&data=04%7C01%7Cbiju.das.jz%40bp.renesas .com%7C948f485a377b4f12c7ea08d934dba3ba%7C53d82571da1947e49cb4625a166a4a2a %7C0%7C0%7C637598940229461664%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAi LCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=4rFbOwmthR BAmn7MNMAHqQD8hm2lgLSKhUNg9i95A5M%3D&reserved=0 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.