Thread (17 messages) 17 messages, 5 authors, 2021-03-25

Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert Freescale DSPI to json schema

From: Vladimir Oltean <olteanv@gmail.com>
Date: 2021-03-16 10:15:56
Also in: linux-spi, lkml

On Tue, Mar 16, 2021 at 06:08:17AM +0000, Kuldeep Singh wrote:
Compatible entries in conjugation require enum and const pair.
For example, ls1012a.dtsi uses compatible = "fsl,ls1012a-dspi","fsl,ls1021a-v1.0-dspi";
Same goes for LS1028 as well.

Therefore, can't mention the compatible entry as single entity otherwise
it may fail "make dt_binding_check" and "make dtbs_check".
quoted
quoted
+examples:
+  - |
+    #include <dt-bindings/clock/fsl,qoriq-clockgen.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    soc {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        spi@2100000 {
+            compatible = "fsl,ls1028a-dspi", "fsl,ls1021a-v1.0-dspi";
This doesn't need the "fsl,ls1021a-v1.0-dspi" compatible, can you please remove
it?
I have taken this example from LS1028a.dtsi and it uses these compatibles in conjugation.
If "fsl,ls1021a-v1.0-dspi" is not required, then it should also be removed from device-tree
As well as from bindings both.
Yes, the second compatible is never required by the driver and should be
removed from existing device trees if that makes "make dtbs_check" fail.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help