Re: [PATCH v5 2/6] Bindings: nvmem: add bindings for JZ4780 efuse
From: Andreas Kemnade <andreas@kemnade.info>
Date: 2020-02-22 15:58:30
Also in:
linux-mips, lkml
On Sat, 22 Feb 2020 11:25:37 +0100 "H. Nikolaus Schaller" [off-list ref] wrote:
quoted hunk ↗ jump to hunk
From: PrasannaKumar Muralidharan <redacted> This patch brings support for the JZ4780 efuse. Currently it only exposes a read only access to the entire 8K bits efuse memory. Tested-by: Mathieu Malaterre <redacted> Signed-off-by: PrasannaKumar Muralidharan <redacted> Signed-off-by: Mathieu Malaterre <redacted> Signed-off-by: H. Nikolaus Schaller <redacted> [converted to yaml] Signed-off-by: Andreas Kemnade <andreas@kemnade.info> --- .../bindings/nvmem/ingenic,jz4780-efuse.yaml | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yamldiff --git a/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml new file mode 100644 index 000000000000..09a8ef937750 --- /dev/null +++ b/Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml@@ -0,0 +1,50 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/ingenic,jz4780-efuse.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Ingenic JZ EFUSE driver bindings + +maintainers: + - PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com> + +allOf: + - $ref: "nvmem.yaml#" + +properties: + compatible: + enum: + - ingenic,jz4780-efuse + + reg: + maxItems: 1 + + clocks: + # Handle for the ahb for the efuse. + maxItems: 1 + + clock-names: + items: + - const: ahb2
as Rob said: probably not needed, since it is a single clock, and the driver uses devm_clk_get(dev, NULL), so it should be prepared for that without any extra work.
+ +required: + - compatible + - reg + - clock-names
so it is not required here (but "- clocks" (not "- clock") as said in earlier mail).
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/jz4780-cgu.h>
+
+ efuse@134100d0 {
+ compatible = "ingenic,jz4780-efuse";
+ reg = <0x134100d0 0x2c>;
+
+ clocks = <&cgu JZ4780_CLK_AHB2>;
+ clock-names = "ahb2";and not required here. Regards, Andreas
Attachments
- (unnamed) [application/pgp-signature] 833 bytes