On 26/08/2019 03:37:43+0000, Biwen Li wrote:

quoted

quoted

On Fri, 2019-08-23 at 17:57 +0800, Biwen Li wrote:

quoted

The patch supports flextimer for lx2160a

Signed-off-by: Biwen Li <redacted>
---
 drivers/rtc/rtc-fsl-ftm-alarm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c

b/drivers/rtc/rtc-fsl- ftm-alarm.c index
4f7259c2d6a3..2b81525f6db8 100644

--- a/drivers/rtc/rtc-fsl-ftm-alarm.c
+++ b/drivers/rtc/rtc-fsl-ftm-alarm.c

@@ -313,6 +313,7 @@ static const struct of_device_id

ftm_rtc_match[] = {
      { .compatible = "fsl,ls1088a-ftm-alarm", },
      { .compatible = "fsl,ls208xa-ftm-alarm", },
      { .compatible = "fsl,ls1028a-ftm-alarm", },
+     { .compatible = "fsl,lx2160a-ftm-alarm", },
      { },
 };

Since there's no data associated with each compatible, it doesn't
seem like there's any need to add a new one.

What's normally done is add two compatibles in the dts, the base
version and the specific version, e.g.:

+               rcpm: rcpm@1e34040 {
+                       compatible = "fsl,lx2160a-rcpm",
+ "fsl,qoriq-cpm-2.1+";

Or in this case, compatible = "fsl,lx2160a-ftm-alarm",
"fsl,ls1088a-ftm-alarm";

Then there's no need to add to the driver list.

Yes, it will be work. But it will be confusing. Is ls1088a same with lx2160a? No.

Well, if you are sure it is the exact same IP that is used, then you should only use
one compatible. We usually use the name of the first SoC that had the IP. Is it
confusing anyone? Probably not because this will be in a dtsi that nobody will
read.

Note that adding so many compatbile will increase the boot time of your
platform and this is annoying many NXP customers of the i.mx line.

Yeah, that makes sense.

--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.
com&data=02%7C01%7Cbiwen.li%40nxp.com%7C3f6abbd69663483bc4
a708d72a0d9999%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6
37024110214068297&sdata=Zh2eYNYt9IjWdf6jCdqY3BI%2F%2Fstgcqmq
Ai7R%2Bm2dD2I%3D&reserved=0