RE: [EXT] Re: [1/3] rtc/fsl: support flextimer for lx2160a
From: Biwen Li <hidden>
Date: 2019-08-26 03:37:51
Also in:
linux-rtc, lkml
On Fri, 2019-08-23 at 17:57 +0800, Biwen Li wrote:quoted
The patch supports flextimer for lx2160a Signed-off-by: Biwen Li <redacted> --- drivers/rtc/rtc-fsl-ftm-alarm.c | 1 + 1 file changed, 1 insertion(+)diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c index 4f7259c2d6a3..2b81525f6db8 100644--- a/drivers/rtc/rtc-fsl-ftm-alarm.c +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c@@ -313,6 +313,7 @@ static const struct of_device_id ftm_rtc_match[] ={ { .compatible = "fsl,ls1088a-ftm-alarm", }, { .compatible = "fsl,ls208xa-ftm-alarm", }, { .compatible = "fsl,ls1028a-ftm-alarm", }, + { .compatible = "fsl,lx2160a-ftm-alarm", }, { }, };Since there's no data associated with each compatible, it doesn't seem like there's any need to add a new one. What's normally done is add two compatibles in the dts, the base version and the specific version, e.g.: + rcpm: rcpm@1e34040 { + compatible = "fsl,lx2160a-rcpm", + "fsl,qoriq-cpm-2.1+"; Or in this case, compatible = "fsl,lx2160a-ftm-alarm", "fsl,ls1088a-ftm-alarm"; Then there's no need to add to the driver list.
Yes, it will be work. But it will be confusing. Is ls1088a same with lx2160a? No.