RE: [PATCH v6 1/7] dt-bindings: usb: hd3ss3220 device tree binding document

Hi Sergei,

Thanks for the feedback.

Subject: Re: [PATCH v6 1/7] dt-bindings: usb: hd3ss3220 device tree binding
document

Hello!

On 05/15/2019 03:09 PM, Biju Das wrote:

quoted

Add device tree binding document for TI HD3SS3220 Type-C DRP port
controller driver.

Signed-off-by: Biju Das <redacted>
Reviewed-by: Rob Herring <robh@kernel.org>
---
V5-->V6
  * No change.
V4-->V5
  * No Change.
V3-->V4
  * No Change.
V2-->V3
  * Added Rob's Reviewed by tag.
V1-->V2
  * Added connector node.
  * updated the example with connector node.
---
 .../devicetree/bindings/usb/ti,hd3ss3220.txt       | 37

++++++++++++++++++++++

quoted

 1 file changed, 37 insertions(+)
 create mode 100644
Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt

diff --git a/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt

b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt
new file mode 100644
index 0000000..7f41400

--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/ti,hd3ss3220.txt

@@ -0,0 +1,37 @@
+TI HD3SS3220 TypeC DRP Port Controller.
+
+Required properties:
+ - compatible: Must be "ti,hd3ss3220".
+ - reg: I2C slave address, must be 0x47 or 0x67 based on ADDR pin.
+ - interrupts: <a b> where a is the interrupt number and b represents an
+   encoding of the sense and level information for the interrupt.

   This depends on an interrupt controller used. I'd just said "an interrupt
specifier", w/o further details.

Fine , If it is ok for everyone. 

Regards,
Biju

quoted

+
+Required sub-node:
+ - connector : The "usb-c-connector" attached to the hd3ss3220 chip. The
+   bindings of the connector node are specified in:
+
+	Documentation/devicetree/bindings/connector/usb-connector.txt
+

[...]

MBR, Sergei