Thread (15 messages) flat view 15 messages, 5 authors, 2019-05-28

RE: [PATCH v6 1/7] dt-bindings: usb: hd3ss3220 device tree binding document

From: Biju Das <hidden>
Date: 2019-05-23 08:56:51
Also in: linux-renesas-soc, linux-usb

Hi Shimoda-San,

Thanks for the feedback.
Subject: RE: [PATCH v6 1/7] dt-bindings: usb: hd3ss3220 device tree binding
document

Hi Biju-san, Morimoto-san,
quoted
From: Biju Das, Sent: Wednesday, May 22, 2019 8:00 PM
<snip>
quoted
quoted
quoted
According to the connector/usb-connector.txt, should the connector
node have ports, port@1 and an endpoint nodes like below?
"ports" is needed if it has multiple "port", otherwise, single port
is allowed from OF-graph point of view.
OK. I will use single port on  the next patch series.
According to the connector/usb-connector.txt [1], even if this device uses a
single port, we should describe ports node and port@1 (for SuperSpeed)
subnode like usb/typec-tcpci.txt.
OK.  I will update the example like below.

hd3ss3220@47 {
	compatible = "ti,hd3ss3220";
	reg = <0x47>;
	interrupt-parent = <&gpio6>;
	interrupts = <3 IRQ_TYPE_LEVEL_LOW>;

	usb_con: connector {
		compatible = "usb-c-connector";
		label = "USB-C";
		data-role = "dual";

		ports {
			#address-cells = <1>;
			#size-cells = <0>;

			port@1 {
				reg = <1>;
				hd3ss3220_ep: endpoint {
					remote-endpoint = <&usb3_role_switch>;
				};
			};
		};
	};
};

Regards,
Biju
[1]
Required nodes:
- any data bus to the connector should be modeled using the OF graph
bindings
  specified in bindings/graph.txt, unless the bus is between parent node and
  the connector. Since single connector can have multiple data buses every
bus
  has assigned OF graph port number as follows:
    0: High Speed (HS), present in all connectors,
    1: Super Speed (SS), present in SS capable connectors,
    2: Sideband use (SBU), present in USB-C.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help