On 5/7/19 7:00 PM, Rob Herring wrote:

On Mon, May 06, 2019 at 05:11:53PM +0200, Lukasz Luba wrote:

quoted

Specifies the AC timing parameters of the LPDDR3 memory device.

Signed-off-by: Lukasz Luba <redacted>
---
  .../devicetree/bindings/ddr/lpddr3-timings.txt     | 58 +++++++++++++
  Documentation/devicetree/bindings/ddr/lpddr3.txt   | 97 ++++++++++++++++++++++
  2 files changed, 155 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/ddr/lpddr3-timings.txt
  create mode 100644 Documentation/devicetree/bindings/ddr/lpddr3.txt

diff --git a/Documentation/devicetree/bindings/ddr/lpddr3-timings.txt b/Documentation/devicetree/bindings/ddr/lpddr3-timings.txt
new file mode 100644
index 0000000..3a2ef3a
--- /dev/null
+++ b/Documentation/devicetree/bindings/ddr/lpddr3-timings.txt

@@ -0,0 +1,58 @@
+* AC timing parameters of LPDDR3 memories for a given speed-bin.
+
+The structures are based on LPDDR2 and extended where needed.
+
+Required properties:
+- compatible : Should be "jedec,lpddr3-timings"
+- min-freq : minimum DDR clock frequency for the speed-bin. Type is <u32>
+- reg : maximum DDR clock frequency for the speed-bin. Type is <u32>
+
+Optional properties:
+
+The following properties represent AC timing parameters from the memory
+data-sheet of the device for a given speed-bin. All these properties are
+of type <u32> and the default unit is ps (pico seconds).
+- tRFC
+- tRRD
+- tRPab
+- tRPpb
+- tRCD
+- tRC
+- tRAS
+- tWTR
+- tWR
+- tRTP
+- tW2W-C2C
+- tR2R-C2C
+- tFAW
+- tXSR
+- tXP
+- tCKE
+- tCKESR
+- tMRD
+
+Example:
+
+timings_samsung_K3QF2F20DB_800mhz: lpddr3-timings@0 {

Now the unit-address should be @800000000

Added @800000000 to the both files.

With that and the other example fixed,

Reviewed-by: Rob Herring <robh@kernel.org>

Thank you.

Regards,
Lukasz