Re: [PATCH v2 18/23] dt-bindings: thermal: armada: add reference to new bindings
From: Rob Herring <robh@kernel.org>
Date: 2018-07-03 21:30:11
Also in:
linux-arm-kernel, linux-pm
On Mon, Jun 25, 2018 at 05:12:34PM +0200, Miquel Raynal wrote:
New bindings (with the syscon and the overheat interrupt) are available
What interrupt? It's not in your new binding.
quoted hunk ↗ jump to hunk
for AP806 and CP110 compatibles. Add a reference to these files from the original documentation. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- Documentation/devicetree/bindings/thermal/armada-thermal.txt | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/Documentation/devicetree/bindings/thermal/armada-thermal.txt b/Documentation/devicetree/bindings/thermal/armada-thermal.txt index e0d013a2e66d..f3b441100890 100644 --- a/Documentation/devicetree/bindings/thermal/armada-thermal.txt +++ b/Documentation/devicetree/bindings/thermal/armada-thermal.txt@@ -10,6 +10,11 @@ Required properties: * marvell,armada-ap806-thermal * marvell,armada-cp110-thermal
Really you should not be using the same compatible for both. Now you have 2 drivers matching to same compatibles. Can't you make this a child of the syscon without breaking the binding?
+Note: these bindings are deprecated for AP806/CP110 and should instead +follow the rules described in: +Documentation/devicetree/bindings/arm/marvell/ap806-system-controller.txt +Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt + - reg: Device's register space. Two entries are expected, see the examples below. The first one points to the status register (4B). The second one points to the control -- 2.14.1