Re: [PATCH v11 5/8] i2c: fsi: Add transfer implementation
From: Wolfram Sang <hidden>
Date: 2018-07-09 22:41:23
Also in:
linux-i2c, lkml
Attachments
- signature.asc [application/pgp-signature] 833 bytes
From: Wolfram Sang <hidden>
Date: 2018-07-09 22:41:23
Also in:
linux-i2c, lkml
+ cmd |= FIELD_PREP(I2C_CMD_ADDR, msg->addr >> 1);
I just noticed this and wonder: Don't you need the LSB of the address? It is not the RW flag, this is encoded in msg->flags. Also, no seperate handling for 10 bit addresses? Technically, 7-bit 0x50 is different on the wire from 10-bit 0x050. This is minor, though. There are no 10-bit devices out there. Still, did you test 10-bit support? Rest looks good.