Re: [PATCH 5/7] arm64: dts: msm8996: Add rpmpd device node
From: Stephen Boyd <sboyd@kernel.org>
Date: 2018-04-09 16:03:22
Also in:
linux-arm-msm, lkml
Quoting Rajendra Nayak (2018-03-15 21:08:22)
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi index 0a6f7952bbb1..43757a078146 100644 --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi@@ -297,6 +297,52 @@ #clock-cells = <1>; }; + rpmpd: qcom,rpmpd {
power-controller? power-domain-controller? power-domains? Or something like that.
+ compatible = "qcom,rpmpd-msm8996";
+ #power-domain-cells = <1>;
+ operating-points-v2 = <&rpmpd_opp_table>, /* cx */
+ <&rpmpd_opp_table>, /* cx_ao */
+ <&rpmpd_opp_table>, /* cx_vfc */
+ <&rpmpd_opp_table>, /* mx */
+ <&rpmpd_opp_table>, /* mx_ao */
+ <&rpmpd_opp_table>, /* sscx */
+ <&rpmpd_opp_table>; /* sscx_vfc */
+ };
+
+ rpmpd_opp_table: opp-table {This should go into the root of the tree? Otherwise it may be populated by the RPMh platform populate code which would be odd. We should go and update the platform populate code to always ignore operating-points-v2 compatible nodes too.
+ compatible = "operating-points-v2", "operating-points-v2-qcom";
This is backwards? I thought more specific compatible went first.