RE: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB and OB

-----Original Message-----
From: Kishon Vijay Abraham I [mailto:kishon@ti.com]
Sent: Friday, November 10, 2017 12:22 AM
To: Xiaowei Bao <redacted>; robh+dt@kernel.org;
mark.rutland@arm.com; catalin.marinas@arm.com; will.deacon@arm.com;
bhelgaas@google.com; shawnguo@kernel.org; Madalin-cristian Bucur
[off-list ref]; Sumit Garg [off-list ref]; Y.b. Lu
[off-list ref]; hongtao.jia@nxp.com; Andy Tang
[off-list ref]; Leo Li [off-list ref]; jingoohan1@gmail.com;
pbrobinson@gmail.com; songxiaowei@hisilicon.com;
devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
kernel@vger.kernel.org; linux-pci@vger.kernel.org; linuxppc-
dev@lists.ozlabs.org; Z.q. Hou [off-list ref]; Mingkai Hu
[off-list ref]; M.h. Lian [off-list ref]
Subject: Re: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB and OB

Hi Bao,

On Friday 10 November 2017 09:18 AM, Bao Xiaowei wrote:

quoted

Add the property of inbound and outbound windows number for ep driver.

Signed-off-by: Bao Xiaowei <redacted>
Acked-by: Minghuan Lian <minghuan.Lian@nxp.com>
---
 v2:
 - no change
 v3:
 - modify the commit message
 v4:
 - no change

 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

$subject should start with something like
arm64: dts: ls1046a: **

quoted

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi

b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 06b5e12d04d8..f8332669663c 100644

--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi

@@ -674,6 +674,8 @@
 			device_type = "pci";
 			dma-coherent;
 			num-lanes = <4>;
+			num-ib-windows = <6>;
+			num-ob-windows = <6>;

EP specific properties shouldn't be added in RC dt node. Ideally you should have
a separate dt node for RC and EP.

It is a single PCIe controller which can be configured to either RC mode or EP mode.  Wouldn't it conflict with the device tree principles to have two device tree nodes for the same PCIe controller?  And obviously the two modes cannot be used at the same time so we cannot have two drivers both probe on the same hardware.

Regards,
Leo