RE: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB and OB

-----Original Message-----
From: Leo Li
Sent: Saturday, November 11, 2017 5:21 AM
To: Kishon Vijay Abraham I <redacted>; Xiaowei Bao
[off-list ref]; robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org;
catalin.marinas-5wv7dgnIgG8@public.gmane.org; will.deacon-5wv7dgnIgG8@public.gmane.org; bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org;
shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; Madalin-cristian Bucur [off-list ref];
Sumit Garg [off-list ref]; Y.b. Lu [off-list ref]; Andy Tang
[off-list ref]; jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; pbrobinson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org;
songxiaowei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org; devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-
kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-
pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Z.q. Hou
[off-list ref]; Mingkai Hu [off-list ref]; M.h. Lian
[off-list ref]
Subject: RE: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB and OB

quoted

-----Original Message-----
From: Kishon Vijay Abraham I [mailto:kishon-l0cyMroinI0@public.gmane.org]
Sent: Friday, November 10, 2017 12:22 AM
To: Xiaowei Bao <redacted>; robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org;
mark.rutland-5wv7dgnIgG8@public.gmane.org; catalin.marinas-5wv7dgnIgG8@public.gmane.org; will.deacon-5wv7dgnIgG8@public.gmane.org;
bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org; shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; Madalin-cristian Bucur
[off-list ref]; Sumit Garg [off-list ref]; Y.b. Lu
[off-list ref]; hongtao.jia-3arQi8VN3Tc@public.gmane.org; Andy Tang
[off-list ref]; Leo Li [off-list ref];
jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; pbrobinson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org; songxiaowei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org;
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org;
linux- kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-
dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org; Z.q. Hou [off-list ref]; Mingkai Hu
[off-list ref]; M.h. Lian [off-list ref]
Subject: Re: [PATCHv4 1/3] ARMv8: dts: ls1046a: add the property of IB
and OB

Hi Bao,

On Friday 10 November 2017 09:18 AM, Bao Xiaowei wrote:

quoted

Add the property of inbound and outbound windows number for ep driver.

Signed-off-by: Bao Xiaowei <redacted>
Acked-by: Minghuan Lian <redacted>
---
 v2:
 - no change
 v3:
 - modify the commit message
 v4:
 - no change

 arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

$subject should start with something like
arm64: dts: ls1046a: **

quoted

diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi

b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 06b5e12d04d8..f8332669663c 100644

--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi

@@ -674,6 +674,8 @@
 			device_type = "pci";
 			dma-coherent;
 			num-lanes = <4>;
+			num-ib-windows = <6>;
+			num-ob-windows = <6>;

EP specific properties shouldn't be added in RC dt node. Ideally you
should have a separate dt node for RC and EP.

It is a single PCIe controller which can be configured to either RC mode or EP
mode.  Wouldn't it conflict with the device tree principles to have two device
tree nodes for the same PCIe controller?  And obviously the two modes cannot
be used at the same time so we cannot have two drivers both probe on the
same hardware.

[Minghuan Lian]  There is only one PCIe dts node in the dts file. PCIe dts node describes the PCIe controller's hardware properties and does not have work mode.  The new properties  "num-ib-windows " and "num-ob-windows" are used to describe the inbound/outbound window number included in the PCIe hardware. These windows are used in both RC and EP mode.  We can change work mode when resetting via RCW(reset configuration word).

Regards,
Leo

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html