Re: [PATCH v2 09/25] mtd: nand: qcom: remove memset for clearing read register buffer
From: Archit Taneja <hidden>
Date: 2017-08-02 06:06:21
Also in:
linux-arm-msm, lkml
On 07/19/2017 05:17 PM, Abhishek Sahu wrote:
The memset in clear_read_regs is overhead. All the register data will be filled by DMA during NAND operation so making these register variables zero is not required.
Yeah, that's a good point. Reviewed-by: Archit Taneja <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Abhishek Sahu <redacted> --- drivers/mtd/nand/qcom_nandc.c | 2 -- 1 file changed, 2 deletions(-)diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c index 5b71478..7ecd0f8 100644 --- a/drivers/mtd/nand/qcom_nandc.c +++ b/drivers/mtd/nand/qcom_nandc.c@@ -826,8 +826,6 @@ static void free_descs(struct qcom_nand_controller *nandc) static void clear_read_regs(struct qcom_nand_controller *nandc) { nandc->reg_read_pos = 0; - memset(nandc->reg_read_buf, 0, - MAX_REG_RD * sizeof(*nandc->reg_read_buf)); } static void pre_command(struct qcom_nand_host *host, int command)
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html