Thread (13 messages) 13 messages, 4 authors, 2017-05-22

Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions

From: Andy Shevchenko <hidden>
Date: 2017-05-22 16:38:04
Also in: linux-i2c, lkml

On Mon, May 22, 2017 at 5:32 PM, Luis Oliveira
[off-list ref] wrote:
On 08-May-17 17:53, Andy Shevchenko wrote:
quoted
On Mon, 2017-05-08 at 11:37 +0100, Luis Oliveira wrote:
quoted
quoted
+            enabled, slave_activity, raw_stat, stat);
+
quoted
+    if (slave_activity) {
+            if (stat & DW_IC_INTR_RD_REQ) {
Looking into next condition (stat & DW_IC_INTR_RX_DONE) I would
exchange these lines
By order? I don't think I understood your point. Please elaborate a little more.
if (stat & DW_IC_INTR_RD_REQ) {
  if (slave_activity) {

And perhaps refactor function a bit.

-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help