Re: [PATCH v9 5/6] i2c: designware: add SLAVE mode functions
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2017-05-11 13:32:32
Also in:
linux-i2c, lkml
On Thu, 2017-05-11 at 16:20 +0300, Jarkko Nikula wrote:
On 05/08/2017 07:53 PM, Andy Shevchenko wrote:quoted
quoted
+ } else if (reg == (DW_IC_COMP_TYPE_VALUE & 0x0000ffff)) {GENMASK(15, 0)I don't think this increase readability compared to 0x0000ffff here.
If it's a defined constant it might do, otherwise I'm fine with explicit value. -- Andy Shevchenko [off-list ref] Intel Finland Oy