Thread (37 messages) 37 messages, 3 authors, 2017-05-09

Re: [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes for V3s SoC

From: Icenowy Zheng <hidden>
Date: 2017-05-05 12:34:34
Also in: dri-devel, linux-arm-kernel, linux-clk, lkml


于 2017年5月5日 GMT+08:00 下午8:30:35, Maxime Ripard [off-list ref] 写到:
On Fri, May 05, 2017 at 04:53:43PM +0800, icenowy-h8G6r0blFSE@public.gmane.org wrote:
quoted
quoted
quoted
+               de2_clocks: clock@1000000 {
+                       compatible =
"allwinner,sun50i-h5-de2-clk";
quoted
quoted
I am a bit skeptical about this. Since the V3S only has one mixer,
do
quoted
quoted
the clocks
for the second one even exist?
It's described in the de_clock.c in the BSP source code, and in
hardware
quoted
these bits can be really set (although without clock output).

So I use this compatible which has still the extra clocks.
If it's not usable, then it shouldn't be in the code, it's basically
dead code.
Thus should we have one more DE2 CCU compatible without mixer1
clocks for V3s?

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help