Thread (37 messages) 37 messages, 3 authors, 2017-05-09

Re: [linux-sunxi] [PATCH v6 11/13] ARM: dts: sun8i: add DE2 nodes for V3s SoC

From: Maxime Ripard <hidden>
Date: 2017-05-05 12:30:39
Also in: dri-devel, linux-arm-kernel, linux-clk, lkml

On Fri, May 05, 2017 at 04:53:43PM +0800, icenowy@aosc.io wrote:
quoted
quoted
+               de2_clocks: clock@1000000 {
+                       compatible = "allwinner,sun50i-h5-de2-clk";
I am a bit skeptical about this. Since the V3S only has one mixer, do
the clocks
for the second one even exist?
It's described in the de_clock.c in the BSP source code, and in hardware
these bits can be really set (although without clock output).

So I use this compatible which has still the extra clocks.
If it's not usable, then it shouldn't be in the code, it's basically
dead code.

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help