Thread (7 messages) 7 messages, 3 authors, 2016-12-22

Re: [PATCH v4 1/2] power: supply: add sbs-charger driver

From: Manish Badarkhe <hidden>
Date: 2016-12-21 10:09:57
Also in: linux-pm, lkml

Hi Nicolas

On Wed, Dec 21, 2016 at 3:00 PM, Nicolas Saenz Julienne
[off-list ref] wrote:
Hi Manish, thanks for the interest.

On 20/12/16 17:54, Manish Badarkhe wrote:
quoted
Hi Nicola
[...]
quoted
Just some general comment, Can you add some more properties here to
know voltage and current?
I assume you are mentioning reading current and voltage values. These
properties are not supported by the sbs-charger standard. All you can do
is set (write only) the charging current and charging voltage values.
Yet in all the boards I've worked with it's the sbs-battery compliant
chip that takes care of it.
thanks for clarifying me.

quoted
Also, can you add other properties present in charging status register
like POWER_FAIL, VOLTAGE_OR,
CURRENT_OR etc.
CURRENT_OR and VOLTAGE_OR relate to wrong values in the charging
voltage/current registers. Since the sbs-battery chip takes care of it I
don't see any use for it.
POWER_FAIL marks there is not enough voltage to charge the battery. I
don't need that information so I did nothing to integrate it. Having a
quick look at the power supply defines I don't see were it could easily fit.
thanks for clarifying me.

Regards
Manish Badarkhe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help