Hi Sergei,

On 09/06/16 15:34, Sergei Shtylyov wrote:

On 6/9/2016 10:53 AM, Roger Quadros wrote:

quoted

It provides APIs for the following tasks

- Registering an OTG/dual-role capable controller
- Registering Host and Gadget controllers to OTG core
- Providing inputs to and kicking the OTG state machine

Provide a dual-role device (DRD) state machine.
DRD mode is a reduced functionality OTG mode. In this mode
we don't support SRP, HNP and dynamic role-swap.

In DRD operation, the controller mode (Host or Peripheral)
is decided based on the ID pin status. Once a cable plug (Type-A
or Type-B) is attached the controller selects the state
and doesn't change till the cable in unplugged and a different
cable type is inserted.

As we don't need most of the complex OTG states and OTG timers
we implement a lean DRD state machine in usb-otg.c.
The DRD state machine is only interested in 2 hardware inputs
'id' and 'b_sess_vld'.

Signed-off-by: Roger Quadros <redacted>

[...]

quoted

diff --git a/drivers/usb/common/usb-otg.c b/drivers/usb/common/usb-otg.c
new file mode 100644
index 0000000..baebe5c
--- /dev/null
+++ b/drivers/usb/common/usb-otg.c

@@ -0,0 +1,833 @@

[...]

quoted

+/**
+ * Change USB protocol when there is a protocol change.
+ * fsm->lock must be held.
+ */

   If you're using the kernel-doc comment, please follow the rules.

All your comments are valid and I'll fix the issues.

<snip>

[...]

   Phew, that was a long patch... normally I don't review the patches that are such big. :-)

Thanks for the patience and review :)