Hi,

On 08/06/16 14:39, Sergei Shtylyov wrote:

Hello.

On 6/8/2016 12:03 PM, Roger Quadros wrote:

quoted

The OTG core will use struct otg_hcd_ops to interface
with the HCD controller.

   Host controller driver (HCD) controller? Maybe just HC? :-)

OK.

quoted

The main purpose of this interface is to avoid directly
calling HCD APIs from the OTG core as they
wouldn't be defined in the built-in symbol table if
CONFIG_USB is m.

Signed-off-by: Roger Quadros <redacted>
Acked-by: Peter Chen <redacted>
---
 include/linux/usb/hcd.h | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index 66fc137..7914bed 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h

@@ -400,6 +400,30 @@ struct hc_driver {

 };

+/**
+ * struct otg_hcd_ops - Interface between OTG core and HCD
+ *
+ * Provided by the HCD core to allow the OTG core to interface with the HCD
+ *
+ * @add: function to add the HCD
+ * @remove: function to remove the HCD
+ * @usb_bus_start_enum: function to immediately start bus enumeration
+ * @usb_control_msg: function to build and send of a control urb

   That "of" is not needed. And it's URB.

Right.

[...]