Re: [PATCH v9 12/14] usb: hcd: Adapt to OTG core
From: Roger Quadros <hidden>
Date: 2016-06-09 07:28:52
Also in:
linux-omap, lkml
On 08/06/16 15:11, Sergei Shtylyov wrote:
On 6/8/2016 3:06 PM, Roger Quadros wrote:quoted
quoted
quoted
Introduce usb_otg_add/remove_hcd() for use by host controllers that are part of OTG/dual-role port. Non Device tree platforms can use the otg_dev argument to specify the OTG controller device. If otg_dev is NULL then the device tree node's otg-controller property is used to get the otg_dev device. Signed-off-by: Roger Quadros <redacted> Acked-by: Peter Chen <redacted> --- drivers/usb/core/hcd.c | 55 +++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/usb/hcd.h | 4 ++++ 2 files changed, 59 insertions(+)diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index ae6c76d..c6f4155 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c[...]quoted
@@ -3025,6 +3030,56 @@ void usb_remove_hcd(struct usb_hcd *hcd) } EXPORT_SYMBOL_GPL(usb_remove_hcd); +static struct otg_hcd_ops otg_hcd_intf = { + .add = usb_add_hcd, + .remove = usb_remove_hcd, + .usb_bus_start_enum = usb_bus_start_enum, + .usb_control_msg = usb_control_msg, + .usb_hub_find_child = usb_hub_find_child, +}; + +/** + * usb_otg_add_hcd - Register the HCD with OTG core. + * @hcd: the usb_hcd structure to initialize + * @irqnum: Interrupt line to allocate + * @irqflags: Interrupt type flags + * @otg_dev: OTG controller device managing this HCDDevice managing a driver? That's interesting. :-)Well it is the OTG controller instance really. How else do you want me to write it?Just HC again? Or maybe HCI (HC interface)?
In my entire series HCD has always meant Host Controller Device. I think I'll leave it the way it is. cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html